Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected Http errors are noisy in the log and sending false positives of issues #444

Closed
dkbennett opened this issue Sep 9, 2024 · 0 comments · Fixed by #443
Closed

Expected Http errors are noisy in the log and sending false positives of issues #444

dkbennett opened this issue Sep 9, 2024 · 0 comments · Fixed by #443
Labels
Issue-Bug Something isn't working or needs investigation Priority-3 Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release
Milestone
DHGE v0.18

Comments

@dkbennett
Copy link
Member

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

have an internet issue, such as internet connection being severed, and observe large exception spam in the logs regarding http request exceptions failing.

Observed in logs from: microsoft/devhome#3778

Expected result

Expected errors that could happen are not treated as catastrophic errors.

Actual result

Connection issues result in a large amount of log spam which can appear to be a problem when it really isn't an issue with the extension.

Included System Information

No response
@dkbennett dkbennett added the Issue-Bug Something isn't working or needs investigation label Sep 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Sep 9, 2024
@dkbennett dkbennett added Priority-3 and removed Needs-Triage New issue that the core contributors need to triage labels Sep 9, 2024
@krschau krschau added the In-PR This issue has a related PR label Sep 10, 2024
@krschau krschau added this to the DHGE v0.18 milestone Sep 10, 2024
@dkbennett dkbennett mentioned this issue Sep 10, 2024
Merged
3 tasks
@krschau krschau added Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release and removed In-PR This issue has a related PR labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug Something isn't working or needs investigation Priority-3 Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release
Projects
None yet
Milestone
DHGE v0.18
Development

Successfully merging a pull request may close this issue.

Add HttpRequestException expected exception handling microsoft/devhomegithubextension
2 participants
@dkbennett @krschau