Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISKSPD should validate that numeric parameters are of expected pattern #10

Open
dl2n opened this issue Oct 22, 2015 · 0 comments
Open

Comments

@dl2n
Copy link
Member

dl2n commented Oct 22, 2015

Validate that numeric parameters follow their expected patterns:

[0-9]+(K|M|G|T) for the ones taking sizes
[0-9]+ for the ones taking plain numbers

For example:

-C10G : invalid, since cooldown only takes plan numeric (validate that all char are [0-9])
-r48h : invalid, since h is not a valid character in the size pattern

The reason -C10G is interesting is that its a somewhat common typo/transpose when -c10G was intended. This would error it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant