Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are debug NGEN images OK? #573

Open
richlander opened this issue May 7, 2020 · 4 comments
Open

Are debug NGEN images OK? #573

richlander opened this issue May 7, 2020 · 4 comments

Comments

@richlander
Copy link
Member

I interrogated .NET Framework 1909 and 1903 images, for 32- and 64-bit.

C:\Users\rich>docker run --rm mcr.microsoft.com/dotnet/framework/runtime:4.8-windowsservercore-1909 c:\Windows\Microsoft.NET\Framework64\v4.0.30319\ngen display | findstr debug
Accessibility, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a <debug>
System.Net, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a <debug>

C:\Users\rich>docker run --rm mcr.microsoft.com/dotnet/framework/runtime:4.8-windowsservercore-1909 c:\Windows\Microsoft.NET\Framework\v4.0.30319\ngen display | findstr debug
Accessibility, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a <debug>
System.Net, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a <debug>

C:\Users\rich>docker run --rm mcr.microsoft.com/dotnet/framework/runtime:4.8-windowsservercore-1903 c:\Windows\Microsoft.NET\Framework64\v4.0.30319\ngen display | findstr debug
Accessibility, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a <debug>
System.Net, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a <debug>

C:\Users\rich>docker run --rm mcr.microsoft.com/dotnet/framework/runtime:4.8-windowsservercore-1903 c:\Windows\Microsoft.NET\Framework\v4.0.30319\ngen display | findstr debug
Accessibility, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a <debug>
System.Net, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a <debug>
@mthalman
Copy link
Member

mthalman commented May 7, 2020

@nattress - Can you provide some context on what <debug> means and why it would be there for these assemblies and not others?

@richlander
Copy link
Member Author

From @jkotas:

These images are compiled with “optimization off”, e.g. here is a command that creates System.Drawing.dll image.

ngen install /nodependencies /debug System.Drawing.dll

These images are used if you configure VS debugger to disable optimizations for everything, so that the whole framework gets the nicer “optimizations off” debugging experience. Nobody does that (intentionally).

We should not have any of these in the docker images.

@richlander
Copy link
Member Author

We need to find out why this is happening.

@mthalman
Copy link
Member

I've logged an internal bug for this work: https://microsoft.visualstudio.com/OS/_workitems/edit/26625219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tracking
Development

No branches or pull requests

3 participants