TaskOrchestrationContextWrapper.CallSubOrchestratorAsync does not provide instance Id properly when RetryPolicy is specified

[ReluXingZeng]

Hello there,

In TaskOrchestrationContextWrapper.CallSubOrchestratorAsync, we have:

durabletask-dotnet/src/Worker/Core/Shims/TaskOrchestrationContextWrapper.cs

Lines 117 to 137 in 9e8997c

	public override async Task<TResult> CallSubOrchestratorAsync<TResult>(
	TaskName orchestratorName,
	object? input = null,
	TaskOptions? options = null)
	{
	// TODO: Check to see if this orchestrator is defined
	static string? GetInstanceId(TaskOptions? options)
	=> options is SubOrchestrationOptions derived ? derived.InstanceId : null;
	string instanceId = GetInstanceId(options) ?? this.NewGuid().ToString("N");
	try
	{
	if (options?.Retry?.Policy is RetryPolicy policy)
	{
	return await this.innerContext.CreateSubOrchestrationInstanceWithRetry<TResult>(
	orchestratorName.Name,
	orchestratorName.Version,
	policy.ToDurableTaskCoreRetryOptions(),
	input);
	}
	else if (options?.Retry?.Handler is AsyncRetryHandler handler)

Where the instanceId extracted from the Option. However, when options?.Retry?.Policy is RetryPolicy policy is enabled, this instanceId is no longer used.

The function CreateSubOrchestrationInstanceWithRetry should support sending instanceId if using the following override:

https://github.com/Azure/durabletask/blob/1bb5c8f964f085bcdd6268c0fb5ec76a0701fb5a/src/DurableTask.Core/OrchestrationContext.cs#L249-L265

I wonder if this needs to be changed