Canonicalize pin paths #4274
Merged
Canonicalize pin paths #4274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
requested review from
Alan-Jowett,
dv-msft,
LakshK98,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag,
shankarseal and
vpidatala94
as code owners
Alan-Jowett
previously approved these changes
Mar 11, 2025
Alan-Jowett
reviewed
Mar 12, 2025
scripts/check_binary_dependencies_ebpfapi_dll_regular_debug.txt
Outdated
Show resolved
Hide resolved
dthaler
force-pushed
the
canonicalize-paths
branch
from
888ff28 to
8717508
Compare
lmb
reviewed
Mar 17, 2025
dthaler
force-pushed
the
canonicalize-paths
branch
5 times, most recently
from
81b2d93 to
a20d9c8
Compare
lmb
reviewed
Mar 19, 2025
dthaler
force-pushed
the
canonicalize-paths
branch
from
bb70b64 to
b5fc392
Compare
dthaler
force-pushed
the
canonicalize-paths
branch
3 times, most recently
from
38dae0b to
180a1c9
Compare
| @@ -325,8 +325,8 @@ function Invoke-CICDTests | |||
| # That causes the regression test to fail. So, we are skipping this test for now. | |||
|
|
|||
| $TestList = @( | |||
| (New-TestTuple -Test "api_test.exe" -Arguments "~`"load_native_program_invalid4`"" -Timeout 600), | |||
| (New-TestTuple -Test "bpftool_tests.exe"), | |||
| (New-TestTuple -Test "api_test.exe" -Arguments "~`"load_native_program_invalid4`" ~pinned_map_enum" -Timeout 600), | |||
There was a problem hiding this comment.
nit: unrelated to this PR: test case load_native_program_invalid4 has been deleted from the repo for some time now. And now that we dont run regression tests against 0.17, we can remove this exclusion of load_native_program_invalid4
There was a problem hiding this comment.
Since unrelated to this PR, please file a separate issue so we can discuss it in triage meeting. :)
|
Added a couple of minor comments. Rest looks fine. |
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Don't test literal pin paths in this tool Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Per feedback from Anurag Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
dthaler
force-pushed
the
canonicalize-paths
branch
from
7ccd608 to
59ad375
Compare
|
@saxena-anurag @lmb please re-review/approve now that I have addressed Anurag's feedback. Thanks! |
saxena-anurag
approved these changes
May 7, 2025
|
@saxena-anurag @lmb please re-review/approve now that I have addressed Anurag's feedback. Thanks! |
|
@Alan-Jowett or @lmb please re-review/approve now that I have addressed Anurag's feedback. Thanks! |
lmb
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ebpf_get_next_pinned_object_path()where the start_path cannot be null.Fixes #4239
Note: on Linux, pin paths are case sensitive, and so any programs ported from Linux may assume case sensitivity.
On Windows, it varies by filesystem, where Windows itself supports both case sensitive filesystems and case insensitive filesystems. The latter is the normal filesystem on Windows, but if we later support a BPF filesystem, we can make it be case sensitive, for ease of porting from Linux. As such, this PR uses case sensitive pin paths. This is not a change for ebpf-for-windows, which already had case-sensitive pin paths.
Testing
This PR contains associated tests.
Documentation
This PR includes a design doc added to the docs directory.
Installation
No impact.