Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add strong-naming to the assembilies inside the nuget package #21

Closed
inthemedium opened this issue Aug 25, 2020 · 2 comments · Fixed by #24
Closed

Please add strong-naming to the assembilies inside the nuget package #21

inthemedium opened this issue Aug 25, 2020 · 2 comments · Fixed by #24

Comments

@inthemedium
Copy link
Member

Please produce strong-name signed assemblies as it makes the assemblies impossible to reference without modification by a project where strong-naming is enabled.

Selenium itself has a separate strong-named package (http://selenium-release.storage.googleapis.com/3.141/selenium-dotnet-strongnamed-3.141.0.zip). The better solution is to strong-name the assemblies and ship it in the existing package, because two packages that contain exactly the same assemblies, types, etc, could cause issues if they are in the same dependency graph.

Example of the current issue as seen in ILSpy:
Microsoft.Edge.SeleniumTools, Version=3.141.1.0, Culture=neutral, PublicKeyToken=null

@bwalderman
Copy link
Contributor

Hi @inthemedium. We can make a separate Microsoft.Edge.SeleniumTools.StrongNamed package available for use with the official Selenium strong-named package. Our existing package depends on the official Selenium.WebDriver NuGet package which is not strong-named.

@bwalderman
Copy link
Contributor

@inthemedium , the strong-named package is now available here: https://github.com/microsoft/edge-selenium-tools/releases/tag/v3.141.2

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants