Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Width is not being respected in Fast-Slider #3634

Closed
uabarahona opened this issue Aug 5, 2020 · 1 comment
Closed

Width is not being respected in Fast-Slider #3634

uabarahona opened this issue Aug 5, 2020 · 1 comment
Labels
closed:done Work is finished improvement A non-feature-adding improvement
Milestone
Release 06

Comments

@uabarahona
Copy link
Contributor

Describe the bug; what happened?

When you set the <fast-slider> width to 0% it is not being respected since it already has a min-width set to:

:host(.horizontal) {
    min-width: calc(var(--design-unit) * 60px);
}

What are the steps to reproduce the issue?

Use the following code:

<!DOCTYPE html>
<html lang="en">

<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
  <title>Repro</title>
</head>

<body>
  <fast-design-system-provider use-defaults>
    <fast-slider min="0" max="100" value="1" style="width:0%"></fast-slider>
  </fast-design-system-provider>

  
  <script type="module" src="https://unpkg.com/@microsoft/fast-components"></script>
</body>

</html>

What behavior did you expect?

The width must be respected when set to 0%,
@uabarahona uabarahona added the status:triage New Issue - needs triage label Aug 5, 2020
@EisenbergEffect EisenbergEffect added area:fast-components improvement A non-feature-adding improvement status:needs-investigation Needs additional investigation and removed status:triage New Issue - needs triage labels Aug 5, 2020
This was referenced Aug 6, 2020
Merged
Merged
Closed
@uabarahona
Copy link
Contributor Author

This issue was already fixed for both fluent and fast, further discussion will continue on #3644

@EisenbergEffect EisenbergEffect added closed:done Work is finished and removed status:needs-investigation Needs additional investigation labels Aug 10, 2020
@EisenbergEffect EisenbergEffect added this to the Release 06 milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed:done Work is finished improvement A non-feature-adding improvement
Projects
None yet
Milestone
Release 06
Development

No branches or pull requests
2 participants
@EisenbergEffect @uabarahona