Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate fixture.ts files once fast-tooling no longer pulls packages from npm registry #4714

Closed
chrisdholt opened this issue May 13, 2021 · 1 comment
Assignees
Labels
chore Maintenance or non-code work closed:by-design Closed by design

Comments

@chrisdholt
Copy link
Member

As part of the vNext updates, the fast-tooling package was updated to pull dependencies from NPM to avoid issues and breaking changes. As part of this, we needed to remove the internal dependency on the local fast-foundation fixture utility and duplicate the those files within tooling.

This issue exists to track the removal of these duplicated files once tooling is again taking its dependency from within the repository.

@chrisdholt chrisdholt changed the title Remove duplicate test-utilities folder once fast-tooling no longer pulls packages from npm registry Remove duplicate fixture.ts files once fast-tooling no longer pulls packages from npm registry May 13, 2021
@janechu janechu self-assigned this May 13, 2021
@EisenbergEffect EisenbergEffect added area:tooling chore Maintenance or non-code work status:planned Work is planned labels May 17, 2021
@janechu
Copy link
Collaborator

janechu commented May 24, 2021

We're going to keep this as a duplicate file, due to the potential for this breaking in the future, as well as the issue of this not being consumer-friendly as it is not documented in any meaningful way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance or non-code work closed:by-design Closed by design
Projects
None yet
Development

No branches or pull requests

3 participants