Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegatesFocus breaks aria-describedby in fast-components #5215

Closed
litteredwitherrors opened this issue Sep 21, 2021 · 3 comments
Closed

delegatesFocus breaks aria-describedby in fast-components #5215

litteredwitherrors opened this issue Sep 21, 2021 · 3 comments
Labels
area:fast-foundation Pertains to fast-foundation bug A bug closed:obsolete No longer valid status:needs-investigation Needs additional investigation

Comments

@litteredwitherrors
Copy link
Collaborator

litteredwitherrors commented Sep 21, 2021

🐛 Bug Report

When the delegatesFocus shadow option is set to true on a component that passes the aria-describedby to a shadow element, when the component receives focus, certain audible assistive technologies will not read corresponding descriptor element.

Google screen reader will read the descriptor.

Potentially effected components:

  • fast-anchor
  • fast-avatar
  • fast-breadcrumb-item
  • fast-button
  • fast-combobox
  • fast-number-field
  • fast-text-field
  • fast-toolbar

💻 Repro or Code Sample

These can be replicated by running fast-components locally and comparing the behavior of fast-button when shadowOptions: { delegatesFocus } is set to true or false when read by Microsoft Narrator or Apple VoiceOver.

🤔 Expected Behavior

<p id="descriptor">Helpful information</p>
<fast-button aria-describedby="descriptor">Button</fast-button>

When the fast-button receives focus, it should read the element with the corresponding ID's inner text (i.e. "Helpful information") when focus is delegated.

😯 Current Behavior

Apple VoiceOver does not read aloud the paragraph element's text "Helpful information" when focus is delegated. Once delegatesFocus is set to false it will be read by the screen reader.

💁 Possible Solution

🔦 Context

🌍 Your Environment

  • OS & Device: MacOS
  • Browser: Microsoft Edge, Google Chrome, Apple Safari
  • Version 11.5
@chrisdholt
Copy link
Member

I think this comes down to an existing platform level problem that we may need to find a workaround for. I mentioned to @EisenbergEffect and @nicholasrice prior, so tagging them here as FYI. On the standards side, this seems to be related to WICG/webcomponents#917 and I think that API would help address this. Unfortunately it seems like these are currently being addressed per attribute so it may take some time for this to populate. We should consider if there is a clear path towards how this will be handled and look to implement our own solution in the meantime if necessary.

@EisenbergEffect EisenbergEffect added status:needs-investigation Needs additional investigation and removed status:triage New Issue - needs triage labels Sep 27, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Apr 16, 2022
@chrisdholt chrisdholt removed the warning:stale No recent activity within a reasonable amount of time label Apr 16, 2022
@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-components has been deprecated for some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-foundation Pertains to fast-foundation bug A bug closed:obsolete No longer valid status:needs-investigation Needs additional investigation
Projects
Status: Done
Development

No branches or pull requests

4 participants