Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: add FAST file selector spec to/in component specs #5269

Closed
3 tasks
litteredwitherrors opened this issue Oct 7, 2021 · 5 comments
Closed
3 tasks

rfc: add FAST file selector spec to/in component specs #5269

litteredwitherrors opened this issue Oct 7, 2021 · 5 comments
Labels
area:fast-foundation Pertains to fast-foundation closed:obsolete No longer valid docs:spec A technical specification status:in-progress Work is in progress warning:stale No recent activity within a reasonable amount of time

Comments

@litteredwitherrors
Copy link
Contributor

💬 RFC

🔦 Context

Seeking feedback for this FAST specification for checkpoint 1.

FAST File Selector

Process

  • Checkpoint 1 - Schedule a spec review meeting to cover the Overview section before proceeding to work on the Design section. Be sure to include relevant stakeholders such as members of the tools team.

  • Checkpoint 2 - Schedule a spec review meeting before beginning the implementation work. Be sure to invite relevant stakeholders such as design system owners.

  • Checkpoint 3 - Submit the component PR and schedule a component code review meeting or present the component in one of our Engineering Open Mic sessions. Address feedback from the review, obtain final approvals through GitHub, and merge.

Overview

A file input is a control that is used to give a user the ability to select files from their computer's file system.

Background

There is currently an existing HTML implementation that is part of the input element specification.

Related issues:
#4726

Use Cases

A user wants to upload a document, such as an image, from their device to the website or web application.

Non-goals

The file input will not utilize the base level javascript file API, but will rather invoke the native HTML element's click() function.

Features

  • Prompts a user to select files to upload
  • Ability to slot in a file list
  • Ability to slot in a button

Risks and Challenges

N/A

Prior Art/Examples


@litteredwitherrors litteredwitherrors added status:triage New Issue - needs triage docs:spec A technical specification labels Oct 7, 2021
@EisenbergEffect EisenbergEffect added area:fast-components area:fast-foundation Pertains to fast-foundation status:in-progress Work is in progress and removed status:triage New Issue - needs triage labels Oct 11, 2021
@EisenbergEffect
Copy link
Contributor

@litteredwitherrors Be sure to reach out to @williamw2. He's got something be built for tools/Creator that might be a good starting point for this work.

@daviddossett
Copy link

Would love to see this implemented. A couple of high-level, from-the-hip thoughts on what would be useful in the Webview UI Toolkit:

  • Positioning of the file(s) value string relative to the button/drag target would be super useful
  • Ability to remove file(s) via an icon button (or at least a slot for one)

I can do some quick sketches for what this would ideally look like in a VS Code extension context if that's helpful.

cc @hawkticehurst @worksofliam

@EisenbergEffect
Copy link
Contributor

@daviddossett Awesome. Concrete use cases from real products are pure gold. Sketches are very welcome.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Apr 16, 2022
@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-components has been deprecated for some time.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-foundation Pertains to fast-foundation closed:obsolete No longer valid docs:spec A technical specification status:in-progress Work is in progress warning:stale No recent activity within a reasonable amount of time
Projects
None yet
Development

No branches or pull requests

4 participants