Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

[Selection list] Aria-selected is not changing the state, is always false #464

Closed
kolaps33 opened this issue Nov 12, 2018 · 1 comment · Fixed by #566
Closed

[Selection list] Aria-selected is not changing the state, is always false #464

kolaps33 opened this issue Nov 12, 2018 · 1 comment · Fixed by #566
Labels
🧰 bug Something isn't working vsts Paired with ticket in vsts

Comments

@kolaps33
Copy link
Collaborator

Bug Report

Steps

Testing with reader require to open it in Edge/Narrator.

  1. Navigate to the selection list item
  2. press down arrow key to move to another list item
  3. press down arrow key to move to another list item
  4. observe aria-selected attribute or listen Narrator.

Expected Result

aria-selected should change state with selected item

Actual Result

aria-selected doesn't change state based on selected item
reader doesn't narrate proper selected state

Version

latest master, before version is v0.11.0

Testcase

@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Nov 12, 2018
@levithomason levithomason added 🧰 bug Something isn't working and removed 🧰 bug Something isn't working labels Nov 30, 2018
@levithomason
Copy link
Member

Confirmed. It appears the aria prop is also not updated on click. We need to update the accessibility behavior to set aria selected based on the item's active prop.

😕 Womp, actually we don't even have a list item active prop. Let's add that first...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 bug Something isn't working vsts Paired with ticket in vsts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants