This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(tooltip): Make tooltip visible for screen reader #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolaps33
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1942 +/- ##
=======================================
Coverage 70.31% 70.31%
=======================================
Files 894 894
Lines 7895 7895
Branches 2287 2287
=======================================
Hits 5551 5551
Misses 2331 2331
Partials 13 13
Continue to review full report at Codecov.
|
layershifter
approved these changes
Sep 18, 2019
jurokapsiar
approved these changes
Sep 19, 2019
Merged
layershifter
pushed a commit
that referenced
this pull request
Sep 26, 2019
(cherry picked from commit 8295ce9)
layershifter
pushed a commit
that referenced
this pull request
Sep 26, 2019
(cherry picked from commit 8295ce9)
layershifter
added a commit
that referenced
this pull request
Sep 26, 2019
* perf(renderComponent): avoid multiple style function calls (#1957) (cherry picked from commit 267a8bc) * fix(tooltip): Make tooltip visible for screen reader (#1942) (cherry picked from commit 8295ce9) * docs: add version header to CHANGELOG * docs: changelog fix header comment * docs: update changelog
layershifter
pushed a commit
that referenced
this pull request
Oct 1, 2019
(cherry picked from commit 8295ce9)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit the scenario that tooltip was not narrated, when was not visible in UI.
Exact usage is, when tooltip is referenced in "aria-labelledby" of the other element.
Solution which could work(at least for screen reader) is hide the tooltip element with opacity: 0