-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack Build Error Due to Nullish Coalescing Operator in Recent Update #591
Comments
I am having the same issue! [14:01:59] Error - [webpack] 'dist':
|
I have run into the exact same stack in an SPFx project using fluentUI. fixed by rolling back to 2.0.203 on the react-icons component. |
Same here trying to run this demo: https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-fluentui-9 Followed all instructions...
|
Ran into the same issue as well and our temporary fix was to use "npm overides" to force React Fluent UI components to use 2.0.203 |
I Ran into the same issue as well. Didn't find a solution unfortunately |
This is still reproducible using version 2.0.207. Had to revert to @fluentui/react-icons 2.0.202 but still not passing while before it was. |
same Problem here... |
The Nullish Coalescing operator from IconDirectionContext was removed in #625 which preceeded 2.0.214. Please confirm you have that, or a later version, or otherwise point to the usage in a more recent version of the library. |
I have installed latest version of fluent ui react components "@fluentui/react-components": "^9.35.1". Which version of fluentuireactcomponents should I install? |
Sorry, but that isn't a dependency of this library (that I'm aware of) and I don't know the answer. Further, I apologize for the confusion, but I suggest you open an issue in the microsoft/fluentui repository related to that package (https://github.com/microsoft/fluentui/tree/master/packages/react-components) |
Hello Fluent UI team,
In a recent change to the
@fluentui/react-icons
package, a syntax error has been introduced which breaks builds using Webpack. The file in question isIconDirectionContext.js
where a nullish coalescing operator (??
) is used.Here is the offending code:
The error message thrown by Webpack is as follows:
This issue seems to stem from the nullish coalescing operator (
??
) not being recognized by certain Webpack configurations. This was not an issue before the recent changes toIconDirectionContext.js
.In the meantime, we have mitigated this issue by reverting to an older version of the
@fluentui/react-icons
package. However, I believe this issue should be addressed at the source. One possible solution could be to revise the use of newer syntax that is not universally supported or to modify the target setting in the tsconfig to ensure the compiled code is compatible with more environments.The line that introduced this issue can be found here.
Thank you for your attention to this matter.
The text was updated successfully, but these errors were encountered: