Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export FluentIcon type via a publicly importable export #656

Closed
dlannoye opened this issue Oct 5, 2023 · 0 comments · Fixed by #657
Closed

Export FluentIcon type via a publicly importable export #656

dlannoye opened this issue Oct 5, 2023 · 0 comments · Fixed by #657

Comments

@dlannoye
Copy link
Member

dlannoye commented Oct 5, 2023

The FluentIcon type used by createFluentIcon and bundleIcon in @fluentui/react-icons is currently not importable without resorting to a deep path not exposed by the exports property in package.json. This type is defined in ./utils/createFluentIcon, but is not exported via the index leading to overhead when trying to build our own custom icons.

Ideally this type would be exposed since it is needed for the types of other public APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant