Skip to content

Commit fcdbee1

Browse files
committed
Move React to devDep and peerDep.
- Move React to devDep and peerDep. Reference: http://stackoverflow.com/a/30454133/1436671 - Release the React semver restriction to 0.14.x. - The peer dependency leaves the App to resolve the React dependencies. - It is a MUST to do so, we cannot guarantee the App is using webpack and leverage dedup. - If not dedup and two React copies run in the page, it leads problems. Like this: facebook/react#1939 - Follow reading the React new version schema: http://facebook.github.io/react/blog/2016/02/19/new-versioning-scheme.html
1 parent d235f85 commit fcdbee1

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

package.json

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,20 @@
1919
"highlight.js": "^8.4.0",
2020
"lodash.merge": "^4.3.2",
2121
"office-ui-fabric": "^2.0.1",
22+
"react": "^0.14.7",
2223
"react-addons-test-utils": "^0.14.3",
24+
"react-dom": "^0.14.7",
2325
"react-highlight": "^0.6.1",
2426
"vinyl-ftp": "^0.4.5",
2527
"web-library-build": "0.0.12",
2628
"webpack-notifier": "^1.2.1",
2729
"webpack-split-by-path": "0.0.8"
2830
},
2931
"dependencies": {
30-
"load-themed-styles": "^1.0.3",
31-
"react": "^0.14.7",
32-
"react-dom": "^0.14.7"
32+
"load-themed-styles": "^1.0.3"
33+
},
34+
"peerDependencies": {
35+
"react": "^0.14.0",
36+
"react-dom": "^0.14.0"
3337
}
3438
}

0 commit comments

Comments
 (0)