Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visio Brand Icons still old #14253

Closed
barisbikmaz opened this issue Jul 30, 2020 · 5 comments
Closed

Visio Brand Icons still old #14253

barisbikmaz opened this issue Jul 30, 2020 · 5 comments
Assignees

Comments

@barisbikmaz
Copy link

barisbikmaz commented Jul 30, 2020

Environment Information

  • Package version(s): 7.98.1

Reproduction

.ms-BrandIcon--visio displays still the old visio icon.
https://static2.sharepointonline.com/files/fabric/assets/brand-icons/product-fluent/png/visio_96x1.png

The documentation but shows the new brand icon.
https://developer.microsoft.com/en-US/fluentui#/styles/web/office-brand-icons

Are you willing to submit a PR to fix? (No)

Requested priority: (Low)

@paulgildea
Copy link
Member

Thanks for the feedback @barisbikmaz !

@paulgildea paulgildea added Area: Icons Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix and removed Needs: Triage 🔍 labels Jul 30, 2020
@xugao
Copy link
Contributor

xugao commented Jul 30, 2020

@Jahnp - could you advice here?

@Jahnp
Copy link
Member

Jahnp commented Aug 3, 2020

Hi @barisbikmaz , thanks for reporting this, and for @xugao for bringing it to my attention!

First, just to be clear, the .ms-BrandIcon--visio code you shared indicates you're seeing an issue with Fabric Core. Fluent UI does not have a component for handling brand icons specifically; see #14151.

However, you are right in that the default icon font in Fluent UI is a little older, and as a result, some of the branded icons that've been updated elsewhere aren't shown on this page:
image

The reason is that we made the choice not to update the @uifabric/icons package in #12088 because of concerns of the linearly growing size of the package, both from a package size and memory footprint perspective. That means Visio, and some other products, didn't get its new icon.

This leaves two paths, one that can unblock you in the short term and one for Fluent UI & Fabric Core:

  1. You can use the Fabric Icons tool to create your own subset that does include the new Visio icon. This is straightforward to create and the icons are drop-in replacements for existing Fluent UI icon uses.
  2. Fluent UI team chooses to allow one remaining update to the @uifabric/icons package to allow these icons to be patched. The same would need to be done in Fabric Core.
  • The cost of doing this would be an increased runtime memory footprint due to the greater number of icon strings. This would have a detrimental effect on users of platforms like the SharePoint Framework, which bundles Fluent UI.

Given the cost and risks, I'd need the Fluent UI team's approval for us to proceed on # 2. I don't personally have a lot of bandwidth here (my focus is on ODSP products) and would need help from someone on the team willing to assist or go to bat with any disagreements.

@xugao , @paulgildea , let me know how we should proceed here!

cc @micahgodbolt for visbiility

@xugao xugao added Needs: Author Feedback and removed Needs: Investigation The Shield Dev should investigate this issue and propose a fix labels Aug 4, 2020
@msft-github-bot
Copy link
Contributor

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fluent UI!

@barisbikmaz
Copy link
Author

Created an issue on fabric/core OfficeDev/office-ui-fabric-core#1232

@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants