Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web components] Badge styling for neutral and accent appearances is applied to host and not control #14397

Closed
chrisdholt opened this issue Aug 7, 2020 · 1 comment · Fixed by #14539
Closed

[web components] Badge styling for neutral and accent appearances is applied to host and not control #14397

chrisdholt opened this issue Aug 7, 2020 · 1 comment · Fixed by #14539
Assignees
@chrisdholt
Labels
Component: Badge Status: Fixed Fixed in some PR Type: Bug 🐛 web-components

Comments

@chrisdholt
Copy link
Member

Environment Information

  • Package version(s): @fluentui/web-components v.latest
  • Browser and OS versions: (fill this out if relevant) N/A

Please provide a reproduction of the bug in a codepen:

  1. Go to: https://codesandbox.io/s/fluent-examples-i92jl?file=/index.html
  2. View "Badge".

Actual behavior:

Notice that the badges with appearances do not have font weight or rounded corners.

Expected behavior:

The badges should have font weight and rounded corner, similar to those using the custom map.
@chrisdholt chrisdholt assigned chrisdholt and unassigned khmakoto Aug 7, 2020
@chrisdholt chrisdholt mentioned this issue Aug 14, 2020
Merged
2 tasks
@msft-github-bot msft-github-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Aug 14, 2020
@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #14539, which has now been successfully released as @fluentui/web-components@v0.1.7.:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrisdholt chrisdholt

Labels
Component: Badge Status: Fixed Fixed in some PR Type: Bug 🐛 web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: apply badge styles to control rather than host element chrisdholt/fluentui
4 participants
@khmakoto @chrisdholt @paulgildea @msft-github-bot