Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpinButton: fix issues revealed by eslint-plugin-react-hooks #14480

Closed
ecraig12345 opened this issue Aug 12, 2020 · 1 comment · Fixed by #15431
Closed

SpinButton: fix issues revealed by eslint-plugin-react-hooks #14480

ecraig12345 opened this issue Aug 12, 2020 · 1 comment · Fixed by #15431
Assignees
@ecraig12345
Labels
Component: SpinButton Status: Fixed Fixed in some PR

Comments

@ecraig12345
Copy link
Member

#14478 enables eslint-plugin-react-hooks for react-next. There were a bunch of issues in SpinButton which would require a good bit of work to fix. I disabled the rule for the file for now but need to go back and actually fix things before release.
@ecraig12345 ecraig12345 self-assigned this Aug 12, 2020
@czearing czearing mentioned this issue Sep 16, 2020
Closed
2 tasks
@czearing czearing mentioned this issue Oct 8, 2020
Merged
2 tasks
@msft-github-bot msft-github-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Nov 30, 2020
@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #15431, which has now been successfully released as @fluentui/react-internal@v8.0.0-beta.20.:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ecraig12345 ecraig12345

Labels
Component: SpinButton Status: Fixed Fixed in some PR
Projects
None yet
Milestone
No milestone
2 participants
@ecraig12345 @msft-github-bot