Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Menu divider visual bug #25097

Closed
2 tasks done
daisygeng opened this issue Oct 5, 2022 · 1 comment · Fixed by #25711
Closed
2 tasks done

[Bug]: Menu divider visual bug #25097

daisygeng opened this issue Oct 5, 2022 · 1 comment · Fixed by #25711
Labels
Component: Menu Fluent UI react-components (v9) Status: Fixed Fixed in some PR

Comments

@daisygeng
Copy link
Collaborator

Library

React Components / v9 (@fluentui/react-components)

System Info

https://aka.ms/fluentui-storybook

Are you reporting Accessibility issue?

No response

Reproduction

https://master--628d031b55e942004ac95df1.chromatic.com/?path=/docs/components-menu-menu--default#visual-divider-only

Bug Description

menu divider

In storybook the divider looks like it is 2 px
image

In the spec, the divider thickness should be mapping to 'strokeWidthThin'
image

Logs

No response

Requested priority

Normal

Products/sites affected

All

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@daisygeng daisygeng mentioned this issue Oct 5, 2022
Merged
@Hirse
Copy link
Member

Hirse commented Oct 23, 2022

I cannot repro this. It looks like 1px to me:
image

@ling1726 ling1726 mentioned this issue Nov 18, 2022
Merged
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Nov 22, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: Menu Fluent UI react-components (v9) Status: Fixed Fixed in some PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: MenuDivider thickness should be strokeWidthThin ling1726/fluentui
4 participants
@Hirse @ling1726 @daisygeng @msft-fluent-ui-bot