Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove screener related secrets now that they are not being used #26086

Closed
micahgodbolt opened this issue Dec 22, 2022 · 1 comment
Closed

Remove screener related secrets now that they are not being used #26086

micahgodbolt opened this issue Dec 22, 2022 · 1 comment
Assignees
@TristanWatanabe
Labels
Area: Build System

Comments

@micahgodbolt
Copy link
Member

micahgodbolt commented Dec 22, 2022 •
edited
Loading

SCREENER_API_KEY and AZURE_STORAGE_CONNECTION_STRING

Also, now that PRs don't need access to these secrets to build, can we change the workflow permissions for token usage?
@micahgodbolt micahgodbolt mentioned this issue Dec 22, 2022
Closed
27 tasks
@micahgodbolt micahgodbolt changed the title Remove SCREENER_API_KEY and AZURE_STORAGE_CONNECTION_STRING? from secrets now that they are not being used Remove SCREENER_API_KEY and AZURE_STORAGE_CONNECTION_STRING from secrets now that they are not being used Dec 22, 2022
@micahgodbolt micahgodbolt changed the title Remove SCREENER_API_KEY and AZURE_STORAGE_CONNECTION_STRING from secrets now that they are not being used Remove screener related secrets now that they are not being used Dec 22, 2022
@TristanWatanabe
Copy link
Member

SCREENER_API_KEY and AZURE_STORAGE_CONNECTION_STRING github secrets have been deleted. screener.key used in the ADO pipelines has also been deleted from the fabric-variables variable group

@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TristanWatanabe TristanWatanabe

Labels
Area: Build System
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@micahgodbolt @TristanWatanabe @msft-fluent-ui-bot