Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Alignment of Web Components and React Components: Issues with Menu closing behavior and adding support for MenuItem Grouping #27042

Closed
1 task done
brianchristopherbrady opened this issue Mar 2, 2023 · 3 comments
Assignees
Labels
Resolution: Soft Close Soft closing inactive issues over a certain period Type: Feature web-components

Comments

@brianchristopherbrady
Copy link
Contributor

brianchristopherbrady commented Mar 2, 2023

Library

Web Components (@fluentui/web-components)

Describe the feature that you would like added

Menu + Menu Item

Issue 1: Change Default Behavior of Menu Closing on Mouse Leave

Description:

Currently, in our Web Component implementation of the Menu, the menu closes on mouse leave. However, the expected behavior is that the Menu should stay open on mouse leave and only close when the mouse is clicked outside the Menu. We need to update our implementation to align with this expected behavior.

Problem:

The current behavior of the menu closing on mouse leave may not be intuitive for users and could lead to frustration or difficulty navigating the menu. Additionally, this behavior does not align with the expected behavior of the Menu and MenuItem components, as well as other common menu implementations.

Delta:

We need to change the default behavior of the Menu component so that it stays open on mouse leave and only closes when the mouse is clicked outside the Menu.

Example:

image
image


Issue 2: Add Support for Menu Grouping, Header, and Split Button to MenuItem Component

Description:

The current implementation of the Menu component in our Web Component library does not support grouping of menu items using the role="group" attribute. As a result, it is difficult to create visually distinct sub-sections within a menu, and the component may not be fully accessible to all users. Additionally, there is a need to create a split button and a header component to support menu grouping. Adding these features will improve the overall accessibility and usability of the Menu and MenuItem components.

Problem:

Without the ability to group menu items with the role="group" attribute, the Menu and MenuItem components cannot meet design requirements for visually distinct sub-sections, and may not be fully accessible to all users. Similarly, the absence of a split button and header component limits the ability to group menu items and provide additional functionality to users.

Delta:

We need to update our implementation of the Menu component to include support for the role="group" attribute, as well as add a split button and header component to support menu grouping.

Example:

Menu item grouping:

image

Split button:

image

Have you discussed this feature with our team

chrisdholt, ling1726

Additional context

No response

Validations

  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@brianchristopherbrady
Copy link
Contributor Author

@ling1726

@microsoft-github-policy-service

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Sep 1, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in @fluentui Web Components Sep 1, 2023
@JustSlone JustSlone reopened this Nov 11, 2023

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Soft Close Soft closing inactive issues over a certain period Type: Feature web-components
Projects
Status: Done
Development

No branches or pull requests

5 participants