Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Implements RFC: slot children render function support decision #27375

Closed
bsunderhus opened this issue Mar 30, 2023 · 1 comment · Fixed by #27472
Closed

[Feature]: Implements RFC: slot children render function support decision #27375

bsunderhus opened this issue Mar 30, 2023 · 1 comment · Fixed by #27472
Assignees
@bsunderhus
Labels
Fluent UI react-components (v9) Status: Fixed Fixed in some PR Type: Feature

Comments

@bsunderhus
Copy link
Contributor

bsunderhus commented Mar 30, 2023 •
edited
Loading

Library

React Components / v9 (@fluentui/react-components)

Describe the feature that you would like added

Follow up on the decision of #27164

Conclusion

We agreed to go with Option C: Custom JSX Pragma without internal changes as it immediately solves the current issue #27089, and then, since Option C doesn't block us to introduce changes on this topic we can decide later for a better solution that would make our codebase smaller/cleaner (Option A or Option D)
@bsunderhus bsunderhus self-assigned this Mar 30, 2023
@bsunderhus
Copy link
Contributor Author

bsunderhus commented Mar 30, 2023 •
edited
Loading

This feature implementation and adoption by each v9 component will fix #27089

@bsunderhus bsunderhus mentioned this issue Apr 4, 2023
Merged
@bsunderhus bsunderhus mentioned this issue Apr 6, 2023
Merged
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Apr 12, 2023
@microsoft microsoft locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsunderhus bsunderhus

Labels
Fluent UI react-components (v9) Status: Fixed Fixed in some PR Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(react-jsx-runtime): implements custom JSX pragma bsunderhus/fluentui
2 participants
@bsunderhus @msft-fluent-ui-bot