Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying explicit font size class overridden by component style #906

Closed
hitendramalviya opened this issue Jan 30, 2017 · 3 comments
Closed

Applying explicit font size class overridden by component style #906

hitendramalviya opened this issue Jan 30, 2017 · 3 comments

Comments

@hitendramalviya
Copy link

Bug Report

  • Package version(s): 1.3.4
  • Browser and OS versions: Chrome Windows 10

Describe the issue:

Applying class ms-font-s to <body class="ms-font-s">...</body> but font-size is overridden by style injected by component and always keeping the same font-size i.e. 14px.
@mdahamiwal
Copy link
Contributor

You will need a more specific selector by adding more classes. If font-size is the only thing you need to control then adding another class on the container should suffice.
http://codepen.io/mdahamiwal/pen/egydeL

@hitendramalviya
Copy link
Author

hitendramalviya commented Feb 15, 2017 •
edited
Loading

Yes we can define more specific selector classes but why each component injecting a separate stylesheet into head section.

If I already included

<link rel="stylesheet" href="https://appsforoffice.microsoft.com/fabric/1.0/fabric.min.css">
<link rel="stylesheet" href="https://appsforoffice.microsoft.com/fabric/1.0/fabric.components.min.css">

into head there is no more required to inject styles for each component. Can we set somewhere not to call style loader.

@cschleiden
Copy link
Contributor

cschleiden commented Apr 11, 2017 •
edited
Loading

Seems like something we can tackle with the new theming/customization work #983

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cschleiden @hitendramalviya @mdahamiwal