Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand lua support to include cmsgpack replacement #722

Open
terinjokes opened this issue Oct 13, 2024 · 2 comments
Open

expand lua support to include cmsgpack replacement #722

terinjokes opened this issue Oct 13, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@terinjokes
Copy link

Feature request type

enhancement

Is your feature request related to a problem? Please describe

Some redis clients, such as the BullMQ library for Node.js, expect the server to have the cmsgpack library loaded into the Lua environment. The cmsgpack library is one of the external libraries documented as loaded in the redis API docs.

Describe the solution you'd like

The two documented functions cmsgpack.pack and cmsgpack.unpack should be added to the Lua environment, likely by using a C# implementation like MessagePack.

Describe alternatives you've considered

No response

Additional context

No response

@badrishc
Copy link
Contributor

badrishc commented Oct 14, 2024

If this is needed, one could also use/update any usable OSS version of cmsgpack to work with NLua. Such as https://github.com/valkey-io/valkey/blob/unstable/deps/lua/src/lua_cmsgpack.c

Same observation holds for struct which is also used by a few scripts out there: https://github.com/valkey-io/valkey/blob/unstable/deps/lua/src/lua_struct.c

Note that NLua is simply a wrapper around KeraLua, which in turn basically packages the latest Lua binaries.

@TalZaccai TalZaccai added the help wanted Extra attention is needed label Oct 15, 2024
@joshkay
Copy link

joshkay commented Nov 13, 2024

Also interested in this. I'm trying to use garnet with BullMQ, but it is not working as a drop in replacement for redis due to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants