Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing of GCToolKit without modules #268

Closed
ghost opened this issue Feb 2, 2023 · 5 comments
Closed

Testing of GCToolKit without modules #268

ghost opened this issue Feb 2, 2023 · 5 comments

Comments

@ghost
Copy link

ghost commented Feb 2, 2023

The NoModuleIntegrationTest in the IT maven module is currently disabled. It is designed to run an end-to-end smoke test of using GCToolKit on the classpath instead of on the module-path. Currently the test runs locally but in the maven build it is run within the module system which fails as the test directly references classes in the vertx module that are not exported. This reference is only for the purposes of the test.

The ask is for finding a solution that would allow for the test to be turned on. The test does make use of JUnit5 @tag annotations so it likely that a maven profile will suffice. That said, any better solution is also welcomed.

@dsgrieve
Copy link
Member

dsgrieve commented Feb 3, 2023

@kirk-microsoft @kcpeppe I believe you may have forgotten to add NoModuleIntegrationTest.java

@ghost
Copy link
Author

ghost commented Feb 3, 2023

@dsgrieve it is there in the IT test folder in the phaser branch. At issue is, I rebased phaser against main a few hours ago, no one has committed anything since then and my local branch of phaser and the github branch are now 1 commit behind main???? With a merge conflict that I fixed... a few hours ago... Unbelievable!

@dsgrieve
Copy link
Member

dsgrieve commented Feb 3, 2023

@kirk-microsoft Okay. It wasn't clear from this issue that the file is in a separate branch. I was under the impression that it was in the main branch. Thanks for the clarification.

@ghost
Copy link
Author

ghost commented Feb 3, 2023

Sorry about that... I was thinking I should have put the complete path in but... got lazy... my bad!

@ghost
Copy link
Author

ghost commented Feb 24, 2023

solution found and implemented

@ghost ghost closed this as completed Feb 24, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant