Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-command hooks are sometimes being called twice #173

Open
wilbaker opened this issue Aug 15, 2019 · 1 comment
Open

Post-command hooks are sometimes being called twice #173

wilbaker opened this issue Aug 15, 2019 · 1 comment

Comments

@wilbaker
Copy link
Member

We've had reports of the post-command hook being called twice.

The current theory is:

[...] something called die/exit while we were running
child[3]. There's a race in run_post_command_hook() that would allow child[4]
to still be started.

@jeffhostetler
Copy link

Could also be that the post-command hook could not be launched (for example, access denied or missing dll or something). This would cause the exec/CreateProcess to return -1 and that could
(I haven't checked the code yet) start shutting things down and cause the atexit() code to run.
Just a theory at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants