Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git: multi-pack-index builtin always shows progress #179

Closed
wilbaker opened this issue Aug 19, 2019 · 2 comments
Closed

Git: multi-pack-index builtin always shows progress #179

wilbaker opened this issue Aug 19, 2019 · 2 comments
Assignees

Comments

@wilbaker
Copy link
Member

Splitting this out as a separate issue from #177

The multi-pack-index builtin shows progress during its output. There is no way to turn it off right now. This means that when we have an error, stderr is filled with progress indicators and the actual error message may be truncated in our logging.

Update git to allow --no-progress and use this argument in the background operations.

@derrickstolee
Copy link
Collaborator

Here are some hints:

You can take most of the changes from #172, but with the following replacements:

  1. builtin/multi-pack-index.c instead of builtin/commit-graph.c.
  2. Documentation/git-multi-pack-index.txt instead of Documentation/git-commit-graph.c
  3. t/t5319-multi-pack-index.sh instead of t/t5318-commit-graph.sh

@wilbaker
Copy link
Member Author

wilbaker commented Nov 8, 2019

Fixed by #186

@wilbaker wilbaker closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants