Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: TestLookupGmailTXT, got [globalsign-smime-dv=CD...KX8=]; want a record containing spf #55

Open
dagood opened this issue Apr 8, 2021 · 0 comments

Comments

@dagood
Copy link
Member

dagood commented Apr 8, 2021

This showed up once in linux-amd64-racecompile in https://dev.azure.com/dnceng/internal/_build/results?buildId=1078273&view=results, then when I removed racecompile, it showed up in linux-amd64-regabi in https://dev.azure.com/dnceng/internal/_build/results?buildId=1078855&view=logs&j=17f0ed56-45c3-5f4e-2883-c1105f3261d7&t=be2aae34-cdee-5b9f-80ac-cc542ed93061&l=352:

--- FAIL: TestLookupGmailTXT (0.00s)
    lookup_test.go:257: got [globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=]; want a record containing spf, google.com
    lookup_test.go:257: got [globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=]; want a record containing spf, google.com
FAIL
FAIL	net	12.192s

(In #52.)

It looks like these are network tests that request DNS info from gmail.com. In some cases these are only run during longtest but it looks like that behavior is explicitly overridden here, enabling them (not skipping them) if it's running in any builder:

go/src/net/dial_test.go

Lines 990 to 998 in bc0c82c

// mustHaveExternalNetwork is like testenv.MustHaveExternalNetwork
// except that it won't skip testing on non-mobile builders.
func mustHaveExternalNetwork(t *testing.T) {
t.Helper()
mobile := runtime.GOOS == "android" || runtime.GOOS == "ios"
if testenv.Builder() == "" || mobile {
testenv.MustHaveExternalNetwork(t)
}
}


Related issues upstream: golang/go#29698, maybe golang/go#22857, golang/go#29722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant