Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLSL Vector Type #356

Merged
merged 13 commits into from
Nov 22, 2024
Merged

HLSL Vector Type #356

merged 13 commits into from
Nov 22, 2024

Conversation

anupamachandra
Copy link
Contributor

Proposing HLSL vector types with length > 4.

Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to merge in so we can begin iterating on it. Thanks!

@anupamachandra
Copy link
Contributor Author

Changed name and added Sponsor. Need one more approving reviewer. Thanks!

@damyanp damyanp requested a review from pow2clk November 22, 2024 21:28
@damyanp
Copy link
Member

damyanp commented Nov 22, 2024

Note that it looks like there's two copies of the spec now, rather than just one with the new filename.

Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think this is good enough to merge, and start iterating on.

anupamachandra and others added 2 commits November 22, 2024 14:07
Co-authored-by: Chris B <beanz@abolishcrlf.org>
Copy link
Member

@pow2clk pow2clk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anupamachandra!

@pow2clk pow2clk merged commit 79140e3 into microsoft:main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants