Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Scalar Converter Code #137

Closed
ksaur opened this issue Jun 15, 2020 · 1 comment · Fixed by #171
Closed

Cleanup Scalar Converter Code #137

ksaur opened this issue Jun 15, 2020 · 1 comment · Fixed by #171
Assignees
@ahmedkrmn
Labels
good first issue Good for newcomers

Comments

@ksaur
Copy link
Contributor

ksaur commented Jun 15, 2020

We have the original draft of the scaler code uploaded in this branch. All credit here goes to @scnakandala, the original author and brains behind this.

It contains an un-edited implementation of RobustScaler, MaxAbsScaler, MinMaxScaler, and StandardScaler here. We need to integrate this old code into the current code.

There is a single test file here that needs to be cleaned up, expanded, and passing.
@ksaur ksaur added the good first issue Good for newcomers label Jun 15, 2020
@ahmedkrmn
Copy link
Contributor

Hi Karla,
Can I work on this one after #145 is merged?

@ahmedkrmn ahmedkrmn mentioned this issue Jun 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmedkrmn ahmedkrmn

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup Scalar Converter Code ahmedkrmn/hummingbird
2 participants
@ksaur @ahmedkrmn