Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup SKL LabelEncoder Converter Code #160

Closed
ksaur opened this issue Jun 19, 2020 · 3 comments
Closed

Cleanup SKL LabelEncoder Converter Code #160

ksaur opened this issue Jun 19, 2020 · 3 comments
Assignees

Comments

@ksaur
Copy link
Contributor

ksaur commented Jun 19, 2020

We have the original draft of the SKL LabelEncoder code uploaded in this branch. All credit here goes to @scnakandala, the original author and brains behind this.

It contains an un-edited implementation of LabelEncoder here.

There is a test file here that needs to be cleaned up and passing (and also tests added for errors).

Notes:

  • We had to treat strings a bit differently because of the way they are represented in tensors
    • We should add more expansive tests
  • In the numeric label encoder, there is a tricky spot here related to running on GPU vs CPU.
    • There may be some bugfixes/improvements that are available now. Our CI/CD pipeline is not currently GPU-enabled, but it would be helpful to be able to run this on a GPU-enabled machine when developing.
@ksaur ksaur added the good first issue Good for newcomers label Jun 19, 2020
@amueller
Copy link

Btw, many people that are using LabelEncoder should actually be using OneHotEncoder. LabelEncoder was meant for labels i.e. targets, not features, and only supports a single column, while OneHotEncoder supports multiple columns.

@interesaaat
Copy link
Collaborator

Good to see you here @amueller! :) Yes we also have OneHotEncoder, it is work in progress in PR #147.

@ksaur ksaur removed the good first issue Good for newcomers label Dec 12, 2020
@ksaur ksaur self-assigned this Dec 12, 2020
@ksaur
Copy link
Contributor Author

ksaur commented Dec 18, 2020

closed via #374

@ksaur ksaur closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants