Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide JsonConverter implementations #282

Closed
ajtribick opened this issue Jul 8, 2024 · 3 comments
Closed

Provide JsonConverter implementations #282

ajtribick opened this issue Jul 8, 2024 · 3 comments
Labels
area:serialization Focused on functional modules of the product Status: No Recent Activity status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close

Comments

@ajtribick
Copy link

Kiota uses custom enum serialization that depends on the EnumMemberAttribute. Unfortunately the JsonStringEnumConverter provided in System.Text.Json does not use this attribute. In order to more easily integrate with non-Kiota uses of System.Text.Json, it would be useful to provide JsonConverter/JsonConverterFactory implementations that match the Kiota output.

Similarly the Date and Time types from Kiota abstractions also don't work directly with System.Text.Json.

@andrueastman
Copy link
Member

Transferring issue as part of #238

@andrueastman andrueastman transferred this issue from microsoft/kiota-serialization-json-dotnet Jul 9, 2024
@andrueastman andrueastman added the area:serialization Focused on functional modules of the product label Jul 9, 2024
@andrueastman andrueastman moved this from Needs Triage 🔍 to Todo 📃 in Kiota Jul 9, 2024
@andrueastman
Copy link
Member

Thanks for raising this @ajtribick

At the moment, the library provides mechanisms for deserializing/serializing with the helper methods as documented at the link below.

https://learn.microsoft.com/en-us/openapi/kiota/serialization?tabs=csharp#serialization-helpers

Any chance you can provide more information as to how the intergration with non Kiota uses would be hindered?

@andrueastman andrueastman added the status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close label Jul 9, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:serialization Focused on functional modules of the product Status: No Recent Activity status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close
Projects
Archived in project
Development

No branches or pull requests

2 participants