Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum serialization should not be changing casing #284

Closed
baywet opened this issue Jun 26, 2024 · 1 comment · Fixed by #312
Closed

Enum serialization should not be changing casing #284

baywet opened this issue Jun 26, 2024 · 1 comment · Fixed by #312
Labels
area:serialization Focused on functional modules of the product WIP

Comments

@baywet
Copy link
Member

baywet commented Jun 26, 2024

https://github.com/microsoft/kiota-serialization-form-dotnet/blob/50d7a29ac768c2f3c0047d8909f12c2df623a30f/src/FormSerializationWriter.cs#L235

(x3 instances)

should be using the enum member attribute instead like here

https://github.com/microsoft/kiota-serialization-json-dotnet/blob/c9c3fe221f52d26322d6b1c8bb562444fdacb4e4/src/JsonSerializationWriter.cs#L539
@baywet baywet mentioned this issue Jun 26, 2024
Merged
@andrueastman
Copy link
Member

Transferring issue as part of #238

@andrueastman andrueastman transferred this issue from microsoft/kiota-serialization-form-dotnet Jul 9, 2024
@andrueastman andrueastman added the area:serialization Focused on functional modules of the product label Jul 9, 2024
@andrueastman andrueastman mentioned this issue Aug 1, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:serialization Focused on functional modules of the product WIP
Projects
Kiota
Archived in project
Milestone
No milestone
2 participants
@andrueastman @baywet