Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexers should be a child of a request builder, not at the same level #2070

Closed
sebastienlevert opened this issue Dec 15, 2022 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request TypeScript Pull requests that update Javascript code
Milestone

Comments

@sebastienlevert
Copy link
Contributor

This affects JavaScript, but probably other languages.

As we are mirroring the indexer behavior of C# (client.Users[id].Get()), it seems that we have hoisted the indexers up in the parent request builders like this:

client.usersById(id).get() versus something that feels more natural like client.users.byId(id).get(). This would also clean the available properties at every level of the request builder chain.

@baywet baywet added TypeScript Pull requests that update Javascript code enhancement New feature or request labels Dec 15, 2022
@baywet baywet added this to the Kiota post-GA milestone Dec 15, 2022
@baywet baywet assigned koros and unassigned nikithauc Feb 24, 2023
@baywet baywet assigned baywet and unassigned koros Apr 24, 2023
@baywet baywet modified the milestones: Backlog, Kiota v1.2 Apr 24, 2023
@baywet
Copy link
Member

baywet commented Apr 24, 2023

@sebastienlevert: we actually already had an issue for that! Closing as already done via #2528

@baywet baywet closed this as completed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TypeScript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

4 participants