Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formats mappings adjustments (breaking batch) #2327

Open
4 tasks
baywet opened this issue Feb 21, 2023 · 2 comments
Open
4 tasks

formats mappings adjustments (breaking batch) #2327

baywet opened this issue Feb 21, 2023 · 2 comments
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Milestone

Comments

@baywet
Copy link
Member

baywet commented Feb 21, 2023

While working on documenting the different format that can be used in OAS I realized Kiota was not mapping some formats properly:

  • "decimal" should only be a child of string type as the serialization process will trim trailing zeros for numbers, loosing precision. => map string:decimal to a string (decimal type) on the wire, and number:decimal to a number (double) on the wire. (BREAKING)
  • "base64" and "base64url" are different in their serialization and deserialization logic, and should ultimately map to stream. (BREAKING)
  • should we add support for char? (BREAKING)
  • type array with uniqueItems: true (items) should map to a hashset
@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. labels Feb 21, 2023
@baywet baywet added this to the Kiota GA milestone Feb 21, 2023
@baywet baywet self-assigned this Feb 21, 2023
@baywet baywet added this to Kiota Feb 21, 2023
@github-project-automation github-project-automation bot moved this to Todo in Kiota Feb 21, 2023
@baywet
Copy link
Member Author

baywet commented Mar 3, 2023

Currently kiota only support OAS 3.0:

Course of action:

  • create a separate issue to fix number/float64, binary, byte BEFORE GA (number won't impact dotnet GA as conversion is always adding format)
  • move this one to v2 as the rest depends on OAS 3.1

@baywet baywet modified the milestones: Kiota GA, Kiota v2 Mar 3, 2023
@baywet baywet changed the title formats mappings adjustments formats mappings adjustments (breaking batch) Mar 3, 2023
@baywet
Copy link
Member Author

baywet commented Jul 19, 2023

@darrelmiller fixing this one will require coordinating all the abstractions and serialization libs on top of changing the generation. I'd recommend pushing it to v3

@baywet baywet removed their assignment Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Projects
Status: Todo 📃
Development

No branches or pull requests

1 participant