-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace symbol's containerName by containerPath #112
Comments
@mickaelistria at least in VS Code we only use the container name for rendering purpose. If we want to transfer a tree then I think we should add a new request to get a symbol tree. Or do I misunderstand anything? |
I found that the symbols request do pass the range of the symbol, which allows to easily show a tree. So I have much less need for containerPath now. Closing this issue as range are working well and are "conceptually" much stronger. |
Hold on a second, is the |
Opened #132 |
Currently, it seems like the containerName in a SymbolInformation uses a convention to use
.
to separate the various segments. However,.
is a valid character for many symbols, so resolving the containerName to a path in the hierarchy can be tricky.Some complex example would be to have a JSon such as
In which case the symbols for
c
both returna.b
as containerName. A correct resolution to parent SymbolInformation requires looking at the positions.An alternative would be to replace a containerName and the
.
convention by a containerPath, that would just be locating the parent as a list of symbols.The text was updated successfully, but these errors were encountered: