Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompletionItemKind missing some kinds from SymbolKind #155

Closed
smarter opened this issue Jan 12, 2017 · 6 comments
Closed

CompletionItemKind missing some kinds from SymbolKind #155

smarter opened this issue Jan 12, 2017 · 6 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@smarter
Copy link
Contributor

smarter commented Jan 12, 2017

I don't get why CompletionItemKind does not extend SymbolKind since you can presumably complete any kind of symbol. In any case, it would be nice if CompletionItemKind provided Namespace or Package since that's a common thing to want completion on.

@felixfbecker
Copy link

I wondered that too! The set of completion items should be a super set of the set of symbol kinds. It makes no sense that there are symbols that cannot be provided for completion, since the editor would already have the icons for it anyway.

@dbaeumer
Copy link
Member

dbaeumer commented Feb 8, 2017

The difference is:

	export const Namespace;
	export const Package;
	export const Constant;
	export const String;
	export const Number;
	export const Boolean;
	export const Array;

I am not sure how useful it is to have String, Number, Boolean and Array as CompletionItemKind. But it doesn't hurt either.

@jrieken can you recall any reasons why we kept them so different.

@felixfbecker
Copy link

I am particularly interested in Namespace

@jrieken
Copy link
Member

jrieken commented Feb 9, 2017

Yeah, no particular reason. Mostly historical reasons, something we can revisit

@dbaeumer
Copy link
Member

dbaeumer commented Feb 9, 2017

OK. Great.

@dbaeumer dbaeumer added this to the March 2017 milestone Feb 9, 2017
@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Apr 11, 2017
@dbaeumer dbaeumer modified the milestones: March 2017, Next, 4.0 Apr 11, 2017
@dbaeumer
Copy link
Member

Dups #129

@dbaeumer dbaeumer removed this from the 4.0 milestone Nov 24, 2017
@dbaeumer dbaeumer added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants