Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uri?: DocumentUri to DocumentSymbol #582

Closed
svenefftinge opened this issue Oct 8, 2018 · 2 comments
Closed

Add uri?: DocumentUri to DocumentSymbol #582

svenefftinge opened this issue Oct 8, 2018 · 2 comments

Comments

@svenefftinge
Copy link
Contributor

svenefftinge commented Oct 8, 2018 •
edited
Loading

The DocumentSymbol data type represents a symbol within a document. So far, the document's uri is implied from the call context.
It would be good to have an optional uri?: DocumentUri field to support usage of the data type in other scenarios, where the document uri cannot be implied from the call:

  • outline (including inherited members)
  • call hierarchy
  • type hierarchy

See also
This was referenced Oct 8, 2018
Closed
Merged
@svenefftinge svenefftinge changed the title Add uri: string to DocumentSymbol Add uri: DocumentUri to DocumentSymbol Oct 8, 2018
@svenefftinge svenefftinge changed the title Add uri: DocumentUri to DocumentSymbol Add uri?: DocumentUri to DocumentSymbol Oct 8, 2018
This was referenced Oct 9, 2018
Closed
Closed
@kittaakos
Copy link

PR: microsoft/vscode-languageserver-node#425

@dbaeumer
Copy link
Member

Closing based on the comments provided in microsoft/vscode-languageserver-node#425

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@svenefftinge @kittaakos @dbaeumer