You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently use notifications to inform server about document changes. This is unfortunate, because the client has to way to figure out which notifications were actually acknowledged by the server. This leads to a situation where client and the server might disagree about the state of the world without realizing that disagreement exists.
See #663 (comment) for a compelling argument why this is problematic (kudos to @rasika for formulating the example)
See #584 for a general discussion of synchronization issues.
This is obviously a breaking change, so we need to do this in the next major version of the protocol.
The text was updated successfully, but these errors were encountered:
matklad
changed the title
To maintain consisntency, use requests and not notifications for changes
To maintain consisntency, use requests instead of notifications for changes
Jan 21, 2019
I think we should mark it as "backlog" and reconsider when/if we will change the shape of notifications. For example #9 (using the same semantics of TextEdit[] as the rest of the protocol and removing redundant rangeLength) looks like something we might want to fix some day as well.
EDIT: I am also fine with just closing, although, imo, receiving responses won't hurt :)
I will close the issue since I don't see us changing this. For now things I stayed away from using notifications unless there is a compelling reason for it (no need for the client to wait for a result).
We currently use notifications to inform server about document changes. This is unfortunate, because the client has to way to figure out which notifications were actually acknowledged by the server. This leads to a situation where client and the server might disagree about the state of the world without realizing that disagreement exists.
See #663 (comment) for a compelling argument why this is problematic (kudos to @rasika for formulating the example)
See #584 for a general discussion of synchronization issues.
This is obviously a breaking change, so we need to do this in the next major version of the protocol.
The text was updated successfully, but these errors were encountered: