Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: The ability to get the current strokes data, and the ability to restore the strokes data #383

Closed
1 task done
jianwenjuan opened this issue Feb 14, 2023 · 3 comments
Labels
enhancement New feature or request live share canvas work Work related to the live-share-canvas sdk package work item

Comments

@jianwenjuan
Copy link

jianwenjuan commented Feb 14, 2023

Please review FAQ and Known issues before filing a new item!

  • I have reviewed the FAQ and known issues and did not find my topic

Please note: any submissions with insufficient reproducible information will be marked as 'Waiting for customer input' and may be closed is there is no response

Describe your user scenario

When I use the live-share-canvas, I want to capture the inking and markup as a snapshot, and saved the strokes from the current inking session. When a snapshot is selected, the current inking session should be replaced with the contents of the snapshot.

Describe the solution you'd like

Provide a clear and concise description of what you want to happen, with code snippets or pseudo code as applicable.

Describe alternatives you've considered

Could you provide a method to get the current strokes data, and provide a method to set the strokes data?

Additional context

Add any other context or screenshots about the feature request here.

@jianwenjuan jianwenjuan added enhancement New feature or request new submission Issues that have been filed and not yet processed by DRI labels Feb 14, 2023
@jianwenjuan jianwenjuan changed the title [Feature Request]: <insert title here> [Feature Request]: <insert title here>The ability to get the current strokes data, and the ability to restore the strokes data Feb 14, 2023
@jianwenjuan jianwenjuan changed the title [Feature Request]: <insert title here>The ability to get the current strokes data, and the ability to restore the strokes data [Feature Request]: The ability to get the current strokes data, and the ability to restore the strokes data Feb 14, 2023
@ryanbliss
Copy link
Contributor

Thanks @jianwenjuan! We have a work item to export the raw strokes and to export the strokes as an SVG. The restoration option seems reasonable. How are you thinking about doing this in your app? Would you store the strokes in a database elsewhere, or are you talking more about undo/redo commands?

@jianwenjuan
Copy link
Author

@ryanbliss Yes, we could store the strokes and the snapshots in a database, then we can restore the strokes data in the shared-canvas, and these strokes could still be shared with other users.

@ryanbliss ryanbliss added work item live share canvas work Work related to the live-share-canvas sdk package and removed new submission Issues that have been filed and not yet processed by DRI labels Feb 21, 2023
@ryanbliss
Copy link
Contributor

Closed with #499, as of version 1.0.0-preview.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request live share canvas work Work related to the live-share-canvas sdk package work item
Projects
None yet
Development

No branches or pull requests

2 participants