Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role Vertification of LiveCanvas not working #676

Closed
httom111 opened this issue Jul 27, 2023 · 5 comments · Fixed by #677
Closed

Role Vertification of LiveCanvas not working #676

httom111 opened this issue Jul 27, 2023 · 5 comments · Fixed by #677
Labels
bug Something isn't working new submission Issues that have been filed and not yet processed by DRI

Comments

@httom111
Copy link

Please review FAQ and Known issues before filing a new item!

  • [ YES ] I have reviewed the FAQ and known issues and did not find my topic

Please note: any submissions with insufficient reproducible information will be marked as 'Waiting for customer input' and may be closed is there is no response

Describe the bug

I am experiencing an issue with the "allowRoles" feature provided by the LiveCanvas library. Specifically, when I set up the system to allow only presenters to modify the canvas, meaning that they can trigger "wet stroke" events. If I understood correctly, only presenters should be able to draw on the canvas, while others should only be able to view it without making modifications. However, in my implementation, attendees are still able to modify the canvas.

To Reproduce

Steps to reproduce the behavior:

Set up the LiveCanvas with only the presenter role allowed to modify the canvas
Attendee attempts to modify the canvas

Expected behavior

I expected that only users with the presenter role would be able to modify the canvas, while attendees would only be able to view it.

Screenshots

UNS}XGJP 1B}QPM7{458T A
SVB$OZLXH@HJDEOVK7B}``V

Desktop(s) (please complete the following information):

  • OS: Windows 10
  • Browser chrome, edge

Additional context

Add any other context about the problem here.

const host = LiveShareHost.create();
const liveShare = new LiveShareClient(host);
const schema: ContainerSchema = { initialObjects: { liveCanvas: LiveCanvas, presence: LivePresence<ICustomUserData> } };
const { container } = await liveShare.joinContainer(schema);
const liveCanvas = container.initialObjects.liveCanvas as LiveCanvas;
const ALLOWED_ROLES = [UserMeetingRole.presenter, UserMeetingRole.organizer];
// Get the canvas host element
const canvasHostElement = document.getElementById("canvas-host");
const inkingManager = new InkingManager(canvasHostElement!);
// Begin synchronization for LiveCanvas
await liveCanvas.initialize(inkingManager, ALLOWED_ROLES);
inkingManager.activate();
@httom111 httom111 added bug Something isn't working new submission Issues that have been filed and not yet processed by DRI labels Jul 27, 2023
@huntj88
Copy link
Contributor

huntj88 commented Jul 27, 2023

I was able to replicate this, looking into it

@huntj88
Copy link
Contributor

huntj88 commented Aug 1, 2023

fix will be deployed in the next release

@httom111
Copy link
Author

httom111 commented Aug 5, 2023

Thank you for your response. Could you please inform me about the expected release date? I am working on a student project and need to plan around the release schedule.

@huntj88
Copy link
Contributor

huntj88 commented Aug 18, 2023

A new release is going out today @httom111

@ryanbliss
Copy link
Contributor

@httom111 v1.0.2 is now published, give it a try and let us know if you run into any issues. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new submission Issues that have been filed and not yet processed by DRI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants