-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VS Code] [Audio] Extension host terminated unexpectedly #1510
Comments
@jasongin to take a look. |
I'm having a similar issue, also on Ubuntu 18.04. |
I'm also having this issue on Ubuntu 18.04. Uninstalling and reinstalling the extension did not resolve. |
Same here! |
i have this problem too |
I have this problem too. Live share works perfectly but cannot start audio call. Ubuntu 18.04 here. |
@jasongin I hit something like this as well in VS Code Insiders on Mac. From: microsoft/vscode#75267
|
@Chuxel the audio extension does not load the native module until you actually try to start/join a call. This error is caused by a crash in native code, not JS. So if you're seeing this crash without tring to start/join a call, then I don't think it would be caused by this extension. |
My extension host crashes upon starting VS Code, so I don't think that the audio part is related to the issue. |
We have made some significant updates to our audio extension with the latest Live Share Audio extension release (0.1.60). I've tried to repro using Ubuntu 19.04 with the latest VS Code and VS Live Share Audio extension and haven't been able to repro. Can you try updating VS Code, and both the Live Share & Live Share Audio extensions to the latest versions and see if this fixes your issue? |
Here it fails silently, only shows 'Connecting audio', then the message disappears. My logs: Product and Version [VS/VSCode]: VSCode 1.38.0-insider When I do the same using the VS Code - Insiders outside WSL, it works fine. |
I too have encountered Extension Host termination on VSCode startup with Live Share. Live Share (not Audio) Extension Update Triggers Extension Host Crash on WindowsHowever, it occurs every time Live Share gets updated for many months now, and even with Windows 10 x64 (instead of Linux) in my case. And it occurs with Live Share extension, even when Live Share Audio extension is disabled. It appears to be related to extension update installation. It occurs every time after each Live Share extension update, and only occurs when those extension updates are installed. Related Issues to Upvote for Fixing Root Cause in VS CodeI've detailed this further at microsoft/vscode#80165 and described how this appears to be a trend affecting many extensions and needing some core Extension Host-level fixes, in microsoft/vscode#79782, and the need for extension isolation in microsoft/vscode#52116. Please upvote and comment on those 3 core VSCode issue reports/requests if believe that this is something that the VSCode core team should prioritize in fixing the root cause (vs. many extension-specific temporary workarounds, considering how many other extensions are affected and the 800+ bug reports across them related to this). Also comment/upvote if you believe that VSCode should improve logging (so can actually identify the extension causing the crash), auto restart the extension host when occurs, and/or implement extension isolation (like I'd proposed in microsoft/vscode#79782) to avoid crashing all extensions when it does occur. |
Related: microsoft/vscode#79116 |
@jramsay can we please try and repro this and see if this persists? |
In my case it may be related to another extension, look at the log:
|
Closing is as resolved, since we believe this issue was fixed and it hasn't been reported in a while. Please re-open it if you're continuing to experience this bug. Thanks! |
Product and Version [VS/VSCode]: VSCode 1.30.2
OS Version [macOS/Windows]: Ubuntu 18.04.02
Live Share Extension Version: 0.3.1100
Target Platform or Language [e.g. Node.js]:
Steps to Reproduce / Scenario:
Create a live share session
Click on start audio call
Extension crashes.
liveshare.zip
The text was updated successfully, but these errors were encountered: