-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] JSON not supported? #34
Comments
I tried csv, json, and both had the same problem. |
After taking a look, I believe there was an assumption that PlainTextConverter class would’ve handled the file extensions mentioned under “Various other text-based formats” in the README. However, the PlainTextConverter class only handles files that mimetypes identifies as text/*, but JSON text for example has a MIME type of application/json. Adding converters for these extensions separately would be the best way to go about fixing this. |
Would a converter that strips JSON text of its nested syntax delimiters be ok for the purpose of "indexing, text analysis" while keeping some indentation (thus loosing e.g. the distinction between key/values and arrays) or should reformatting it into e.g. tables be more useful for this project ? |
I could be wrong, but in my case, the problem with text formats was solved when I installed the "mime-support" package additionally in the docker container |
You are correct. This was my assumption, and it was wrong. I'll address this asap. |
Based on the README, I see that JSON is a supported extension, however, when I passed a sample JSON to it, I get the following error:
Please look into this, thanks!
The text was updated successfully, but these errors were encountered: