Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying authentication providers #359

Closed
mslukebo opened this issue May 16, 2024 · 0 comments · Fixed by #360
Closed

Add support for specifying authentication providers #359

mslukebo opened this issue May 16, 2024 · 0 comments · Fixed by #360
Assignees
Labels
engine enhancement New feature or request Medium Difficulty of task (T-shirt size).

Comments

@mslukebo
Copy link
Contributor

Is your feature request an entirely new concept?
Yes.

Is your feature request related to an existing component?
No.

Is your feature request related to a problem? Please describe.
In many situations, a plugin may require performing some kind of authentication (e.g. fetching access tokens on behalf of a user). Currently, a plugin would need to implement all the logic for performing the authentication. This can cause issues where, from the perspective of the user, authentication flows "randomly" happen.

Describe the solution you'd like
Authentication flows should happen at the application (SDK Driver) layer, not at the plugin layer. A plugin should initiate these flows, but the logic for how they happen should be defined by the application. Specifically, the application environment should provide ways to fetch classes that can provide authentication flows. Engine users should also be able to provide these classes, which then are added to the engine application environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine enhancement New feature or request Medium Difficulty of task (T-shirt size).
Projects
None yet
1 participant