Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change in Appearance of AppBarButton with Flyout on CommandBar in WinUI3 Desktop #2714

Closed
eleanorleffler opened this issue Jun 19, 2020 · 2 comments
Closed

Change in Appearance of AppBarButton with Flyout on CommandBar in WinUI3 Desktop #2714

eleanorleffler opened this issue Jun 19, 2020 · 2 comments
Labels
appModel-win32 Exclusive to WinUI 3 Win32 Desktop apps area-Commanding AppBar, UICommand, MVVM, etc duplicate This issue or pull request already exists product-winui3 WinUI 3 issues team-Controls Issue for the Controls team

Comments

@eleanorleffler
Copy link

Describe the bug

We used a CommandBar with AppBarButton with a Flyout in our UWP application. However, once we switched over to WinUI3 Desktop, the appearance of the button changed.

The button in the WinUI application has a ">" next to the icon whereas the UWP application did not.

See Screenshots below to compare differences.

Steps to reproduce the bug

  1. Clone the WinUI3 Problems CommandBarFlyout repository.
  2. Go to the CommandBarFlyoutWinUI folder.
  3. Open the CommandBarFlyoutWinUI solution in Visual Studio 2019 Preview.
  4. Build and run with Debug x64.
  5. Notice the additional ">" next to the first icon in the CommandBar on the right side of the application.

Expected behavior

We expect to see no difference in the UWP and WinUI3 Desktop CommandBar buttons. The button in the WinUI3 Desktop application should only be the AppBarButton icon.

Build and run the CommandBarFlyoutUWP inside the CommandBarFlyoutUWP folder to see expected behavior.

Screenshots

CommandBarFlyoutExpectedAppearance

Screenshot#1 - Expected Appearance (UWP)

CommandBarFlyoutCurrentAppearance

Screenshot#2 - Current Appearance (WinUI3 Desktop)

Version Info

NuGet package version:

[Microsoft.VCRTForwarders.140 1.0.6]
[Microsoft.WinUI 3.0.0-preview1.200515.3]

Targeting:

Target: Universal Windows
Target version: Windows 10, version 1809 (10.0; Build 17763)
Min version: Windows 10, version 1809 (10.0; Build 17763)

Windows 10 version Saw the problem?
Insider Build (xxxxx)
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763) Yes
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Mobile
Xbox
Surface Hub
IoT
@eleanorleffler eleanorleffler mentioned this issue Jun 19, 2020
Closed
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jun 19, 2020
@StephenLPeters StephenLPeters added area-Commanding AppBar, UICommand, MVVM, etc appModel-win32 Exclusive to WinUI 3 Win32 Desktop apps team-Controls Issue for the Controls team product-winui3 WinUI 3 issues and removed needs-triage Issue needs to be triaged by the area owners labels Jun 22, 2020
@marb2000
Copy link
Contributor

Sorry for the late response.
@eleanorleffler, I think that we already sync the UWP and Desktop styles. Closing this bug. Please, feel free to open it in case I miss something.

@eleanorleffler
Copy link
Author

Hi @marb2000 ,

I have actually opened a new issue for Preview 4 (#4197) - closing this issue is fine, but the bug can be replicated in Preview 4!

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 1, 2021
@StephenLPeters StephenLPeters added duplicate This issue or pull request already exists and removed needs-triage Issue needs to be triaged by the area owners labels Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
appModel-win32 Exclusive to WinUI 3 Win32 Desktop apps area-Commanding AppBar, UICommand, MVVM, etc duplicate This issue or pull request already exists product-winui3 WinUI 3 issues team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StephenLPeters @eleanorleffler @marb2000 @msft-github-bot