Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberBox control is not completely accessible #3174

Closed
alekhyareddy28 opened this issue Aug 21, 2020 · 4 comments
Closed

NumberBox control is not completely accessible #3174

alekhyareddy28 opened this issue Aug 21, 2020 · 4 comments
Labels
area-NumberBox NumberBox Control duplicate This issue or pull request already exists

Comments

@alekhyareddy28
Copy link

Describe the bug

The number box control is composed on a spinner and a text box. However, the name that we set for the number box is only applied to the spinner but the editable text box has a null name property.

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Run accessibility insights on a NumberBox.

Expected behavior

When the Accessible name property is set using AutomationProperties there should not be any error thrown in Accessibility insights regarding the name not being set.

Screenshots

The following screenshots are of the xaml controls gallery. This is just an example. Tried to set the AutomationProperty.Name in numerous ways. Also tried to use AutomationProperties.LabeledBy but the name does not percolate to the edit textbox.

image
image
image
The name that we set percolates only to the spinner and not to the edit textbox, thereby throwing an error with accessibility insights which cannot be programmatically set in any other way because it is encapsulated in the <muxc:NumberBox> control.

Version Info

NuGet package version:

Microsoft.UI.Xaml 2.5.0-prerelease.200708003

Windows app type:

UWP Win32
Yes
Windows 10 version Saw the problem?
Insider Build (xxxxx)
May 2020 Update (19041)
November 2019 Update (18363)
May 2019 Update (18362) Yes
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes/No
Xbox
Surface Hub
IoT

Additional context

Linked Issue in PowerToys - microsoft/PowerToys#6082

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Aug 21, 2020
@marcelwgn
Copy link
Collaborator

I think, at the end of the day, this is the same issue as #2951.

@alekhyareddy28
Copy link
Author

@chingucoding thank you. Will look at that issue.

@robloo
Copy link
Contributor

robloo commented Aug 21, 2020

@chingucoding Yes, I think it is the same issue.

@ranjeshj ranjeshj added area-NumberBox NumberBox Control duplicate This issue or pull request already exists and removed needs-triage Issue needs to be triaged by the area owners labels Aug 21, 2020
@ranjeshj
Copy link
Contributor

closing since this is a dup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NumberBox NumberBox Control duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

5 participants