Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance degradation on showing huge content #3335

Closed
Xarlot opened this issue Sep 26, 2020 · 8 comments
Closed

Performance degradation on showing huge content #3335

Xarlot opened this issue Sep 26, 2020 · 8 comments
Assignees
Labels

Comments

@Xarlot
Copy link

Xarlot commented Sep 26, 2020

While investigating WinUI 3 Desktop performance I`ve observed a performance degradation on showing new windows with huge content.

Describe the bug
Every new window with huge content shows 20% times slower compared to the previous.

Steps to reproduce the bug

  1. Create a window with 1000 number boxes
  2. Subscribe to Loaded event
  3. Activate it
  4. Repeat from step 1

Sample project App10.zip
Click a "click me" button, the result will be shown in the title.

Expected behavior
There is no difference between activations

Version Info
Package version 3.0.0-preview2.200713.0
AppModel WinUI 3 Desktop
OS Name Microsoft Windows 10 Enterprise
OS Version 10.0.19041 N/A Build 19041

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Sep 26, 2020
@Xarlot Xarlot changed the title Performance degradation while showing huge content Performance degradation on showing huge content Sep 26, 2020
@lhak
Copy link

lhak commented Sep 27, 2020

I think have seen a similar issue (not sure if related) where the performance degrades after the window size was changed a few times. This could especially be seen with XAML animations.

@ranjeshj
Copy link
Contributor

This might be related to this leak in cs/winrt. . @Xarlot can you check task manager and see if memory usage is increasing each time you activate ? @Scottj1s as FYI

@ranjeshj ranjeshj added the team-Markup Issue for the Markup team label Sep 28, 2020
@Xarlot
Copy link
Author

Xarlot commented Sep 29, 2020

It seems my steps to reproduce weren't good.
You should create and activate a new window each time. I`ve updated the description

@BorzillaR
Copy link

I upgrade the origin project to Preview 3. The performance issue still here.

Window num Load time
1 5949
2 7242
3 9553
4 12310
5 15862

Each next window loads about 20% slower than the previous.

Updated project:
App10.zip

@stevenbrix
Copy link
Contributor

Thanks @BorzillaR and @Xarlot.

@bartekk8 can you see if this is still reproing on the latest?

@JeanRoca
Copy link

JeanRoca commented Feb 3, 2021

@Austin-Lamb would someone on your team be able to look at this?

@JeanRoca JeanRoca added team-Reach Issue for the Reach team and removed team-Markup Issue for the Markup team labels Feb 3, 2021
@bartekk8
Copy link
Contributor

bartekk8 commented Feb 4, 2021

Thanks for reporting this issue. I verified and it still repros on the latest. The repro app creates multiple windows with a lot of content and in such case a slowdown is to be expected, but when windows are destroyed the perf should improve. Unfortunately, it doesn't, so It looks like there's a leak here! Again, thanks for catching it!

@bpulliam bpulliam removed the needs-triage Issue needs to be triaged by the area owners label Oct 8, 2021
@pratikone pratikone added team-Rendering Issue for the Rendering team and removed team-Reach Issue for the Reach team labels Dec 6, 2022
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 6, 2022
@bpulliam bpulliam removed the needs-triage Issue needs to be triaged by the area owners label Dec 6, 2022
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants