Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determinate ProgressRing not filling based off of the value entered #3787

Closed
MarissaMatt opened this issue Dec 9, 2020 · 14 comments · Fixed by #6691
Closed

Determinate ProgressRing not filling based off of the value entered #3787

MarissaMatt opened this issue Dec 9, 2020 · 14 comments · Fixed by #6691
Labels
area-Progress ProgressBar, ProgressRing help wanted Issue ideal for external contributors team-Controls Issue for the Controls team wct

Comments

@MarissaMatt
Copy link
Contributor

Describe the bug
There are a few issues with the determinate progress ring not filling the circle correctly when a particular value is set. These values are described below:

Value of 50 isn't half of the circle:
image

Values aren't determinate. Setting a value doesn't result in the same behavior all the time:
image

The above means that in many cases there is no visual increment when incrementing between numbers (every value should show a discrete amount of the arc when the control is large enough on screen):
image

(I saw it go for 3-4 steps without moving, and then this seemed to cause a large jump between 99 and 100 at times.)

The ring isn't completely filled at 100 (you can still see the end caps of the segment):
image

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 9, 2020
@StephenLPeters StephenLPeters added area-Progress ProgressBar, ProgressRing team-Controls Issue for the Controls team help wanted Issue ideal for external contributors and removed needs-triage Issue needs to be triaged by the area owners labels Dec 12, 2020
@StephenLPeters
Copy link
Contributor

@karenbtlai I think I remember there being some code which ensures that 99/100 looks clearly distinct from 100/100. Is this code causing this?

@MarissaMatt
Copy link
Contributor Author

@StephenLPeters @karenbtlai part of it could be with the Lottie file as well so I will reach out to design and see if they can help.

@mdtauk
Copy link
Contributor

mdtauk commented Dec 18, 2020

If I were working on the Animation file, I would have Keyframes for:

  • 0%
  • 1%
  • 25%
  • 50%
  • 75%
  • 99%
  • 100%

@michael-hawker
Copy link
Collaborator

Originally posted from: #3767 (comment)

@jp-weber
Copy link
Contributor

Any new info on this? It would be great if with WinUI 2.6 release the ProgressRing would work properly.

@HppZ
Copy link

HppZ commented Jun 12, 2021

microsoft is not good at UI & UX.

@michael-hawker
Copy link
Collaborator

@MarissaMatt @karenbtlai @StephenLPeters any updates? Can this be put in the 2.6 milestone?

@michalleptuch
Copy link

Any new info on this?

@MarissaMatt
Copy link
Contributor Author

@ranjeshj @karenbtlai could we look to see if the lottie file is not aligning with the value of the progress ring?

@jp-weber
Copy link
Contributor

Any news?

@MarissaMatt
Copy link
Contributor Author

@jp-weber yes, we are testing out a new Lottie file that will fix some of the inconsistencies the community is noticing but there is an underlying code issue that we are trying to work through as well. I'm hoping to have another update by the end of this week. Thank you all for your patience on this!

@jp-weber
Copy link
Contributor

@MarissaMatt thank you for the first update. What also would be interested, if the update have an inpact for the issue #4636 where the rendering of the ProgressRing will be destroyed, when the ProgressRing is in a CommandBar.

@MarissaMatt
Copy link
Contributor Author

Thanks for bringing this to my attention as well! I will talk to the dev team to see if that issue is due to something going on with the ProgressRing rendering or if it's an AppBar issue.

@MarissaMatt
Copy link
Contributor Author

@StephenLPeters would this be a fix for this bug as well? #4636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Progress ProgressBar, ProgressRing help wanted Issue ideal for external contributors team-Controls Issue for the Controls team wct
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants