[C++/WinRT] Can't declare a string in Page.Resources with x:Name set

[JaiganeshKumaran]

Describe the bug
In C++/WinRT, you can't set a name for a string inside Page.Resources/UserControl.Resources/ContentDialog.Resource as the XAML compiler generates invalid code for the getter and setter. It uses winrt::System::String as the type for x:String in XAML markup instead winrt::hstring which is the right one.

Steps to reproduce the bug

Steps to reproduce the behavior:

1. Define a string in Page.Resources with a name instead of UI
2. Build the app
3. See error

Expected behavior

XAML compiler will generate the correct getter and setter for string values.

Screenshots

Version Info

Package version: WinUI 2.6.0-prerelease.210217002
Visual Studio version: 16.9.0
Windows version: 20H2 Build 19042.804

NuGet package version:

Windows app type:

UWP	Win32
Yes

Windows 10 version	Saw the problem?
Insider Build (xxxxx)
October 2020 Update (19042)	Yes
May 2020 Update (19041)
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)

Device form factor	Saw the problem?
Desktop	Yes
Xbox
Surface Hub	Yes
IoT

[StephenLPeters]

@RealTommyKlein FYI @fabiant3

[github-actions]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[JesseCol]

Hi, does this repro in WinAppSDK / WinUI3? Thanks!

[JaiganeshKumaran]

Hi, does this repro in WinAppSDK / WinUI3? Thanks!

Yes, it does.