Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple exceptions in IE when using a codelens provider #1004

Closed
foxable opened this issue Aug 14, 2018 · 3 comments
Closed

Multiple exceptions in IE when using a codelens provider #1004

foxable opened this issue Aug 14, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone

Comments

@foxable
Copy link

foxable commented Aug 14, 2018

monaco-editor version: 0.14.2
Browser: IE 11
OS: Windows 10

Steps or JS usage snippet reproducing the issue:

  1. Open the Codelens provider example from the Playground in IE 11
  2. The expected codelens does not appear in the first line. Instead, the exceptions listed below occur.
  3. Further exceptions occur when trying to trigger the IntelliSense widget using Ctrl + Space.
TypeError: Unable to get property 'length' of undefined or null reference
   at e.prototype._renderCodeLensSymbols (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:1567:923)
   at Anonymous function (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:1566:435)
   at t (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:210:605)
   at g (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:119:180)
   at P.enter (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:122:536)
   at _run (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:124:387)
   at _completed (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:123:847)
   at Anonymous function (https://microsoft.github.io/monaco-editor/
TypeError: Unable to get property 'map' of undefined or null reference
   at e.prototype.updateDecorations (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:1207:529)
   at Anonymous function (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:1207:144)
   at t (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:210:605)
   at g (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:119:180)
   at P.enter (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:122:536)
   at _run (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:124:387)
   at _completed (https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js:123:847)
   at Anonymous function (https://microsoft.github.io/monaco-editor/node_mod
@alexdima alexdima self-assigned this Aug 14, 2018
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Aug 14, 2018
@alexdima alexdima added this to the On Deck milestone Aug 14, 2018
@kpreisser
Copy link

Hi,

the issue with the IntelliSense widget not working in IE 11 in Monaco Editor 0.14.3 also occurs when using a TypeScript document; e.g. if you simply open https://microsoft.github.io/monaco-editor/ in IE and in the TypeScript code press Ctrl + Space on any line.

Additionally, other widgets like "Find all References" are not working in IE.

This currently blocks us from updating the Monaco Editor in our product, because we still have to use the WebBrowser control in .NET that uses IE.

Thanks!

@alexdima alexdima added important Issue identified as high-priority ie11 labels Aug 31, 2018
@blutorange
Copy link
Contributor

It was not working for me in IE as well. I did investigate for a bit and found that the promise polyfill used by vscode has a bug with chaining: microsoft/vscode#57722 (now fixed).

Not certain if this is the same issue, but it was working in IE11 for me after I added a different promise polyfill.

@alexdima alexdima modified the milestones: On Deck, October 2018 Nov 12, 2018
@alexdima
Copy link
Member

I have just tried, and this is fixed on master

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

4 participants